-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add video MIME types to Documenter.display_dict
#2552
base: master
Are you sure you want to change the base?
Conversation
Two thoughts here:
|
For 1. I think it only becomes a problem if an object support all of the video formats and all three are rendered but perhaps this is common? Or is there generally just one implemented? As a side note, some people complain about slow build times because of the display_dict so perhaps the mimes should somehow be filtered keeping in mind that not all options may end up being used. |
Rendering multiple videos is actually something I didn't even consider, but I agree, this is also something we should think about. My concern was mostly about existing docs with many complex figures now potentially rendering heaps of videos though.
I'm not sure how we should approach this, but doing something about that wouldn't hurt, I agree. |
But are there objects which have both a video representation and image representations? I would expect it to be mutually exclusive? |
I wouldn't be surprised if animations would fall back to the first frame maybe? But whether that's actually common, I don't know. |
Just a passing thought: I wonder if we could do a kind of a "look ahead" here, and query the writer for a list of MIMEs it wants/supports, and then just render the first one? |
That could be cool, let's discuss on Tuesday |
Following from what was discussed on the community call a couple of months ago. Still WIP and I will have to test locally.