Remove Pkg as a dependency #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In recent Julia versions Pkg is not in the sysimage and therefore it can not be loaded "for free". Pkg was only used to conditionally activate the documentation environment in `LiveServer.servedocs` so the loss of functionality is basically non-existent -- it is easy enough to configure the package environment before calling `LiveServer.servedocs`. Timings for loading LiveServer on Julia 1.12: ``` julia> @time using LiveServer # this PR 0.448249 seconds julia> @time using LiveServer # master 0.743163 seconds ```
|
Bump! |
tlienart
approved these changes
Oct 22, 2024
|
thanks a lot @fredrikekre ; will merge & release would you be interested in becoming a contributor for this repo since I'm unfortunately not doing a great job at the moment, it'd definitely help to have someone else who can merge and release stuff 😄 |
|
Sure! If you want to transfer it somewhere it could perhaps live in the JuliaDocs organization? |
|
added you as collaborator, happy to transfer this repo to JuliaDocs 👍 |
|
I invited you to JuliaDocs, you should be able to transfer once you join the org. |
|
All done, thanks 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent Julia versions Pkg is not in the sysimage and therefore it can not be loaded "for free". Pkg was only used to conditionally activate the documentation environment in
LiveServer.servedocsso the loss of functionality is basically non-existent -- it is easy enough to configure the package environment before callingLiveServer.servedocs.Timings for loading LiveServer on Julia 1.12: