Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stagger and step method for approximating chaotic saddles #148
base: main
Are you sure you want to change the base?
Stagger and step method for approximating chaotic saddles #148
Changes from all commits
f8acbd8
b7a049f
9109255
c7231cd
f9d89c1
48720c3
b1e88b2
07a7fac
1ebfdc4
8307847
6b224f2
97ba3e1
82ebc34
dbd0a1a
2bf31cc
ecbcd9b
dd294a8
fcbf177
0b8abe7
b509e66
64d0028
1ad10fb
3684c67
6ca9c79
3fe26ac
79ac79b
f3b1a6b
bc271cb
dd88f06
6635187
01aec42
2c96f0b
0c80f32
f6db227
cdcbd9f
92ccb8f
382910b
ab4d092
4d9b2ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why you do this extra step here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is step part of the
stagger_and_step
. If theescape_time!
is < Tm then we execute a step. If not, we look for a neighbor that fulfill the condition and after this we do one step.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function can be made significantly more performant by creating dedicated structs that store the dummy variables to reduce allocations, and are then used as function-like-objects. I can do this small change once the PR is ready to go.