Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API 2.0 #107

Merged
merged 83 commits into from
Jan 25, 2022
Merged

API 2.0 #107

merged 83 commits into from
Jan 25, 2022

Conversation

kahaaga
Copy link
Member

@kahaaga kahaaga commented Jan 21, 2022

This is the cleaned-up version of #97 (which I am keeping temporarily, to have access to timings). When tests pass and documentation looks ok, we can merge this and delete #97.

@kahaaga
Copy link
Member Author

kahaaga commented Jan 22, 2022

All the examples in the documentation seem to do what I'd expect them to do, so this is good to merge from my side.

That is actually not true. The LombScargle example looks off. I'll have a look over the weekend.

@Datseris
Copy link
Member

Just tag me when you want a final review here!

@kahaaga
Copy link
Member Author

kahaaga commented Jan 24, 2022

@Datseris I've removed redundant comments and tried to style the code in a more paragraph-like style. Not all comments were removed, because I still think they're useful, but comments are not in place during every step anymore.

I also think the IrregularLombScargle example works fine now. The mistake was that I set the default number of maximum iterations too low, so that the Lomb-Scargle periodogram of the surrogate wouldn't converge sufficiently to the periodogram of the original surrogate. This is now fixed.

Should be ready for another review.

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kahaaga wow, now that's one huge amount of work, congrats! I think I went through all of the PR. I've left only really small comments that you can easily address. Feel free to merge after you have addressed the comments!

src/api.jl Outdated Show resolved Hide resolved
src/api.jl Outdated Show resolved Hide resolved
src/api.jl Outdated Show resolved Hide resolved
src/methods/large_shuffle.jl Outdated Show resolved Hide resolved
src/methods/pseudoperiodic.jl Outdated Show resolved Hide resolved
src/methods/truncated_fourier.jl Show resolved Hide resolved
src/methods/truncated_fourier.jl Outdated Show resolved Hide resolved
src/methods/truncated_fourier.jl Outdated Show resolved Hide resolved
src/utils/interpolation.jl Outdated Show resolved Hide resolved
src/utils/powerspectrum.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants