-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API 2.0 #107
API 2.0 #107
Conversation
Took too long to run.
That is actually not true. The LombScargle example looks off. I'll have a look over the weekend. |
Just tag me when you want a final review here! |
@Datseris I've removed redundant comments and tried to style the code in a more paragraph-like style. Not all comments were removed, because I still think they're useful, but comments are not in place during every step anymore. I also think the Should be ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kahaaga wow, now that's one huge amount of work, congrats! I think I went through all of the PR. I've left only really small comments that you can easily address. Feel free to merge after you have addressed the comments!
Co-authored-by: George Datseris <[email protected]>
Co-authored-by: George Datseris <[email protected]>
Co-authored-by: George Datseris <[email protected]>
Co-authored-by: George Datseris <[email protected]>
Co-authored-by: George Datseris <[email protected]>
Co-authored-by: George Datseris <[email protected]>
Co-authored-by: George Datseris <[email protected]>
Co-authored-by: George Datseris <[email protected]>
This is the cleaned-up version of #97 (which I am keeping temporarily, to have access to timings). When tests pass and documentation looks ok, we can merge this and delete #97.