Add imaging_mode support (static compilation) #125

jpsamaroo · 2020-12-01T20:13:05Z

We can tell Julia that we want it to emit symbols instead of session-specific pointers, making our code (potentially) relocatable. I'm not locked in on this API, but it was pretty easy to implement. Known issues include Symbols embedded in the IR; they show up as {}* null in the LLVM IR for some reason. I've tested that I can roundtrip very simple functions (including closures) through codegen(:obj, ...)+dlopen/dlsym.

codecov · 2020-12-02T06:06:23Z

Codecov Report

Merging #125 (b2524b5) into master (2c4a304) will decrease coverage by 8.15%.
The diff coverage is 20.00%.

❗ Current head b2524b5 differs from pull request most recent head 4b3cf11. Consider uploading reports for the commit 4b3cf11 to get more accurate results

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   79.79%   71.63%   -8.16%     
==========================================
  Files          22       22              
  Lines        1628     1590      -38     
==========================================
- Hits         1299     1139     -160     
- Misses        329      451     +122

Impacted Files	Coverage Δ
src/jlgen.jl	`78.57% <ø> (+8.89%)`	⬆️
src/native.jl	`0.00% <0.00%> (-100.00%)`	⬇️
src/interface.jl	`51.11% <100.00%> (-26.86%)`	⬇️
src/bpf.jl	`0.00% <0.00%> (-92.86%)`	⬇️
src/gcn.jl	`0.00% <0.00%> (-67.68%)`	⬇️
src/validation.jl	`56.11% <0.00%> (-40.69%)`	⬇️
src/error.jl	`4.34% <0.00%> (-26.09%)`	⬇️
src/GPUCompiler.jl	`81.81% <0.00%> (-18.19%)`	⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4a304...4b3cf11. Read the comment docs.

maleadt · 2021-03-03T12:16:11Z

Base PR has been merged; needs an update here?

jpsamaroo · 2021-03-03T12:55:02Z

Yes indeed! How do you feel about me having the extra field in FunctionSpec? Do you want me to remove this functionality from all except the Native backend for now?

maleadt · 2021-03-03T13:13:21Z

I'm not sure. It's not really a property of the source function, is it? Maybe an extern_policy(::CompilerJob) interface? Aren't the Julia compiler policy (wether to emit symbols or pointers) and the code relocation models two different (if not related) aspects too?

jpsamaroo · 2021-03-03T13:24:07Z

I'm not sure. It's not really a property of the source function, is it? Maybe an extern_policy(::CompilerJob) interface?

The reason I shoved static into FunctionSpec is that I assume that imaging mode for GPUCompiler could break some functionality, so I didn't want it enabled globally for any backend until I was sure it worked "perfectly". Nevermind, I misread your comment. Yes, that makes sense to me!

Aren't the Julia compiler policy (wether to emit symbols or pointers) and the code relocation models two different (if not related) aspects too?

I combined these under the assumption that if you're emitting symbols, you probably want to be able to emit relocatable code for shared libraries (since we can actually do that now!). If you want them to be split concepts, how should reloc be specified to llvm_machine?

jpsamaroo · 2021-03-04T00:16:32Z

I setup a few tests, although they won't get run unless you have a recent enough build of Julia. Some of them are skipped because they don't yet work with imaging mode (probably either bugs or missing functionality in Julia), but they should work eventually.

maleadt · 2021-03-04T06:55:45Z

Some of them are skipped because they don't yet work with imaging mode (probably either bugs or missing functionality in Julia), but they should work eventually.

Better make those a @test_broken then so that we get informed when they start passing?

I combined these under the assumption that if you're emitting symbols, you probably want to be able to emit relocatable code for shared libraries (since we can actually do that now!). If you want them to be split concepts, how should reloc be specified to llvm_machine?

Yeah I'm not sure, feel free to keep both aspects linked for now, it's not like GPUCompiler.jl has a stable API or anything 🙂

jpsamaroo · 2021-03-04T12:15:46Z

Better make those a @test_broken then so that we get informed when they start passing?

Unfortunately, the thing that's broken is that the IR gets generated just slightly wrong, so we just get a segfault 🙂

Yeah I'm not sure, feel free to keep both aspects linked for now, it's not like GPUCompiler.jl has a stable API or anything slightly_smiling_face

I definitely can separate them in the future, when users end up requesting the ability to differentiate.

jpsamaroo · 2021-03-04T19:04:43Z

Added an extern flag to the Native target which determines the policy, and left reloc to do exactly what it says.

src/native.jl

test/native.jl

vchuravy · 2021-03-04T19:15:18Z

test/native.jl

+    @test_skip ccall(generate_shlib_fptr(f5, ()), Symbol, ()) == :asymbol
+    f6(x) = x == :asymbol ? true : false
+    @test_skip ccall(generate_shlib_fptr(f6, (Symbol,)), Bool, (Symbol,), :asymbol)
+    @test_skip !ccall(generate_shlib_fptr(f6, (Symbol,)), Bool, (Symbol,), :bsymbol)


At least one of these test should run in an external process.

In reality, anything that relies on runtime calls/state should probably go through another process. I'll spool one up with Distributed and see how far I can get.

This approach was very enlightening, if also unfortunate. I found that we still emit things like Symbols and some other objects as inttoptr'd pointers. I'm going to have one of the simpler tests run on another process, but clearly there's still some extra work to be done.

jpsamaroo · 2021-06-09T21:03:36Z

Should I gate Julia global externalization/internalization behind an interface function, or are we okay with keeping it as always-on?

maleadt · 2021-06-10T05:56:58Z

src/driver.jl

+        if LLVM.linkage(gbl) == LLVM.API.LLVMInternalLinkage &&
+           typeof(LLVM.initializer(gbl)) <: LLVM.PointerNull &&
+           (startswith(LLVM.name(gbl), "jl_global") ||
+            startswith(LLVM.name(gbl), "jl_sym"))


Why also jl_sym, not just jl_global (in a function that externalizes globals)?

maleadt · 2021-06-10T05:59:09Z

Should I gate Julia global externalization/internalization behind an interface function, or are we okay with keeping it as always-on?

Do we emit such globals in other scenarios? We're starting to have a lot of interface functions...

gbaraldi · 2022-06-02T21:08:37Z

@jpsamaroo what was the state of this, I'm thinking of rebasing it since it's the most common error we are hitting right now.

jpsamaroo · 2022-06-03T13:41:30Z

Aside from this not actually switching on imaging mode (as I pointed out on Slack), I think this mostly was working.

vchuravy · 2022-06-03T15:00:15Z

I think the issue that this is has is that it doesn't do the processing of the global variables. So you end up with uninitialized GVs and no way to know what's supposed to go in there?

brenhinkeller · 2023-05-13T14:35:00Z

Even without global variables, seems like this could be useful for StaticCompiler if it lets us use more of libjulia!

jpsamaroo added enhancement New feature or request needs tests needs documentation labels Dec 1, 2020

jpsamaroo force-pushed the jps/static-compile branch from 9ab6adc to 4d52463 Compare March 4, 2021 00:14

jpsamaroo marked this pull request as ready for review March 4, 2021 00:15

jpsamaroo removed the needs tests label Mar 4, 2021

jpsamaroo force-pushed the jps/static-compile branch from 4d52463 to b2524b5 Compare March 4, 2021 19:03

vchuravy reviewed Mar 4, 2021

View reviewed changes

Add imaging_mode support (static compilation)

9fbe9cc

jpsamaroo force-pushed the jps/static-compile branch from b2524b5 to 4b3cf11 Compare June 9, 2021 19:10

Temporarily externalize Julia globals

4b3cf11

jpsamaroo marked this pull request as draft June 9, 2021 19:14

Address review comments

9e5a8f5

Test ccall of fptr in another process

a39ba24

maleadt reviewed Jun 10, 2021

View reviewed changes

tshort mentioned this pull request Sep 9, 2021

GPUCompiler rewrite tshort/StaticCompiler.jl#43

Closed

maleadt force-pushed the master branch from 628b8dd to f3f2c5e Compare September 5, 2023 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add imaging_mode support (static compilation) #125

Add imaging_mode support (static compilation) #125

jpsamaroo commented Dec 1, 2020 •

edited

Loading

codecov bot commented Dec 2, 2020 •

edited

Loading

maleadt commented Mar 3, 2021

jpsamaroo commented Mar 3, 2021

maleadt commented Mar 3, 2021

jpsamaroo commented Mar 3, 2021 •

edited

Loading

jpsamaroo commented Mar 4, 2021

maleadt commented Mar 4, 2021

jpsamaroo commented Mar 4, 2021 •

edited

Loading

jpsamaroo commented Mar 4, 2021

vchuravy Mar 4, 2021

jpsamaroo Jun 9, 2021

jpsamaroo Jun 9, 2021

jpsamaroo commented Jun 9, 2021

maleadt Jun 10, 2021

maleadt commented Jun 10, 2021

gbaraldi commented Jun 2, 2022

jpsamaroo commented Jun 3, 2022

vchuravy commented Jun 3, 2022

brenhinkeller commented May 13, 2023

Add imaging_mode support (static compilation) #125

Are you sure you want to change the base?

Add imaging_mode support (static compilation) #125

Conversation

jpsamaroo commented Dec 1, 2020 • edited Loading

codecov bot commented Dec 2, 2020 • edited Loading

Codecov Report

maleadt commented Mar 3, 2021

jpsamaroo commented Mar 3, 2021

maleadt commented Mar 3, 2021

jpsamaroo commented Mar 3, 2021 • edited Loading

jpsamaroo commented Mar 4, 2021

maleadt commented Mar 4, 2021

jpsamaroo commented Mar 4, 2021 • edited Loading

jpsamaroo commented Mar 4, 2021

vchuravy Mar 4, 2021

Choose a reason for hiding this comment

jpsamaroo Jun 9, 2021

Choose a reason for hiding this comment

jpsamaroo Jun 9, 2021

Choose a reason for hiding this comment

jpsamaroo commented Jun 9, 2021

maleadt Jun 10, 2021

Choose a reason for hiding this comment

maleadt commented Jun 10, 2021

gbaraldi commented Jun 2, 2022

jpsamaroo commented Jun 3, 2022

vchuravy commented Jun 3, 2022

brenhinkeller commented May 13, 2023

jpsamaroo commented Dec 1, 2020 •

edited

Loading

codecov bot commented Dec 2, 2020 •

edited

Loading

jpsamaroo commented Mar 3, 2021 •

edited

Loading

jpsamaroo commented Mar 4, 2021 •

edited

Loading