-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GI.convert for Makie plots, allow arrays #108
Conversation
@jw3126 I swapped this over to just using Arrays of geometries are working fine now (except where they don't work with GeometryBasics either) but the plot type detection isn't working - an array of polygons is plotted as a scatter with Also @asinghvi17 that removes all your |
I saw you skipped some tests, were these broken before, or does this PR break them? |
I removed You could instead use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok cool LGTM thanks!
@asinghvi17 I took the liberty of making a PR from your branch, I have this array code somewhere too but we may as well merge this instead.
Float64
is also better for high resolution things, going on the FLoat32 artifacts we see at high zooms in Tyler.jl....A test of plotting the vectors could help I guessdone