-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement crstrait
.
#140
Implement crstrait
.
#140
Conversation
I think we would also want similar traits in GFT or some kind of trait wrapper, so that users can choose to have CRS traits evaluated at compile time too! It should be possible to detect this using Proj I think. |
Agreed, this is would be the setup for that. For now, the default UnknownTrait() should be compiled away. |
"An ProjectedTrait for all projected coordinate reference systems" | ||
struct ProjectedTrait <: AbstractProjectedTrait end | ||
"An UnknownTrait for all unknown (assumed projected) coordinate reference systems" | ||
struct UnknownTrait <: AbstractProjectedTrait |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this inherit from AbstractCRStrait?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we assume projected anyway then dispatch can just be on AbstractProjectedTrait
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I assume you implement GeometryOps with Abstractprojected and catch both.
To distinguish between geographic and projected coordinate systems. Fixes #119.