Type stable calc extent #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks nice! Can we add a test for the type stability (or hit the missing coverage)? |
|
Its a small union optimisation, so its not guaranteed to be inferred, just fast. I'll try to get the code coverage up |
|
@evetion this is good to go if you could approve, coverage is passing (needs a squash and cleanup rather than merge tho) |
evetion
reviewed
Aug 7, 2023
| Extent(; X, Y) | ||
| end | ||
| end | ||
| calc_extent(t::GeometryCollectionTrait, geom) = reduce(Extents.union, (extent(f) for f in getgeom(t, geom))) |
There was a problem hiding this comment.
pedantry: note that we call extent (and thus accept pre-calculated extents) for multigeoms instead of calling calc_extent (recalculating everything). Old behaviour and quite pragmatic, but it might be slightly unexpected.
evetion
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@asinghvi17 hit some very slow code with Rasters.jl and GeometryBasics.jl where I had forgotten to use
fallbacks=false.But it seems it can be a lot faster by using
is3dto in worst case get small union optimisations (but mostly compiled away), getting the extrema over all points in a geometry in one pass, and avoiding collecting points or makingNamedTupleat the leaf nodes of the geometry.