Add deprecated messages for the next breaking release (v0.7.0)
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
===========================================
- Coverage 100.00% 98.67% -1.33%
===========================================
Files 1 1
Lines 199 227 +28
===========================================
+ Hits 199 224 +25
- Misses 0 3 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I'm not sure we really need additional tests for |
sethaxen
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming
v0.7.0version is going to have the following breaking changes.normalize,normalizea,normalizeq(Drop normalize for quaternions #69)normfield (Do we really need normalized-flag inQuaternion? #60 Remove norm field and update normalization functions #108)Complex-Quaternioncompatibility (ShouldComplexbe convertible toQuaternion? #62)This PR adds deprecated messages to these functions and their methods.