Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples for v1.89 #110

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Update examples for v1.89 #110

merged 1 commit into from
Jan 14, 2024

Conversation

JamesWrigley
Copy link
Member

Overview of important changes:

Fixes #76 🤞 Tested by opening all of the sections and playing around with them.

Overview of important changes:
- Renamed `ShowDemoWindow()` to `ShowJuliaDemoWindow()` to avoid confusion with
  the official demo, and use it by default in `examples/demo.jl`.
- Use `unsafe_load()` where appropriate.
- `ImDrawCornerFlags_*` -> `ImDrawFlags_RoundCorners*`:
  https://github.com/ocornut/imgui/blob/docking/imgui.h#L3515
- `AddBezierCurve()` -> `AddBezierCubic()`:
  https://github.com/ocornut/imgui/blob/docking/imgui.h#L2927
- Use explicit key ranges in `demo_misc.jl`:
  - https://github.com/ocornut/imgui/blob/docking/imgui.h#L949
  - https://github.com/ocornut/imgui/blob/docking/imgui.h#L2122
@JamesWrigley JamesWrigley requested a review from Gnimuc January 14, 2024 14:17
@JamesWrigley JamesWrigley self-assigned this Jan 14, 2024
@Gnimuc Gnimuc merged commit 1132364 into master Jan 14, 2024
32 checks passed
@Gnimuc
Copy link
Member

Gnimuc commented Jan 14, 2024

Thanks! 😘

@JamesWrigley JamesWrigley deleted the update-examples branch January 14, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example code doesn't actually run
2 participants