Skip to content

Commit

Permalink
Factor out warning
Browse files Browse the repository at this point in the history
  • Loading branch information
BioTurboNick committed Dec 8, 2023
1 parent 060b437 commit 0d011c0
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
5 changes: 1 addition & 4 deletions src/imfilter.jl
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,7 @@ end

# Step 5: if necessary, pick an algorithm
function imfilter!(out::AbstractArray, img::AbstractArray, kernel::ProcessedKernel, border::AbstractBorder)
if any(x -> (isa(x, Adjoint) || isa(x, Transpose)) && isa(x.parent, OffsetVector) && first(OffsetArrays.center(x.parent)) != 1, kernel)
@warn "A transposed OffsetVector automatically has an index of 1 in the first dimension. \
Consider using an OffsetMatrix to control the index of each dimension."
end
_warn_if_transposed_from_offset_vector(kernel)
imfilter!(out, img, kernel, border, filter_algorithm(out, img, kernel))
end

Expand Down
11 changes: 11 additions & 0 deletions src/utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,14 @@ accumfilter(pixelval::Colorant{N0f8}, filterval::N0f8) = float32(c)*Float32(filt
# In theory, the following might need to be specialized. For safety, make it a
# standalone function call.
safe_for_prod(x, ref) = oftype(ref, x)

function _warn_if_transposed_from_offset_vector(kernel::ProcessedKernel)
if any(_is_transposed_offset_vector, kernel)
@warn "A transposed OffsetVector automatically has an index of 1 in the first dimension. " *
"Consider using an OffsetMatrix to control the offset of each dimension."
end
end

_is_transposed_offset_vector(x::Adjoint{<:Any, <:OffsetVector}) = Base.has_offset_axes(parent(x))
_is_transposed_offset_vector(x::Transpose{<:Any, <:OffsetVector}) = Base.has_offset_axes(parent(x))
_is_transposed_offset_vector(_) = false

0 comments on commit 0d011c0

Please sign in to comment.