Fix show for images with offset axes #6
Conversation
|
I should have mentioned, I saw three solutions:
The reason I chose this approach is that it's not entirely clear what the output array's axes should be when calling |
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
===========================================
- Coverage 97.87% 62.33% -35.54%
===========================================
Files 2 2
Lines 47 77 +30
===========================================
+ Hits 46 48 +2
- Misses 1 29 +28
Continue to review full report at Codecov.
|
src/showmime.jl
Outdated
| @@ -42,6 +45,9 @@ function Base.show(io::IO, mime::MIME"image/png", img::AbstractMatrix{C}; | |||
| end | |||
| end | |||
|
|
|||
| Base.show(io::IO, mime::MIME"image/png", img::OffsetArray{C}; kwargs...) where C = | |||
There was a problem hiding this comment.
should C be restricted to Colorant? I guess it doesn't matter for a non Colorant when the MethodError(show, ...) is thrown one level deeper (it should just continue to walk the display stack). But I am guessing that it messes with the result of showable which falls back to hasmethod. thoughts?
Fixes JuliaImages/Images.jl#717. CC @zygmuntszpak (who is not watching but commented on that issue).