Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unitary matrices in svd/eigen of Diagonal be unitless #1155

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dkarrasch
Copy link
Member

Follow-up to #1150 and the discussion therein.

test/diagonal.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.89%. Comparing base (97a712f) to head (530fcee).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/diagonal.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   91.92%   91.89%   -0.04%     
==========================================
  Files          34       34              
  Lines       15353    15355       +2     
==========================================
- Hits        14113    14110       -3     
- Misses       1240     1245       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/diagonal.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants