Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #669

Closed
wants to merge 2 commits into from
Closed

Update README.md #669

wants to merge 2 commits into from

Conversation

nlw0
Copy link

@nlw0 nlw0 commented Feb 28, 2022

Couple of typos. Not sure about the second one, the previous sentence was "from of Julia Code", and it was changed to "form of Julia Code", but I have a feeling the correct should be "from Julia Code", does that make sense?

Couple of typos. Not sure about the second one, the previous sentence was "from of Julia Code", and it was changed to "form of Julia Code", but I have a feeling the correct should be "from Julia Code", does that make sense?
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.25%. Comparing base (fefaab9) to head (222a041).
Report is 10 commits behind head on master.

Current head 222a041 differs from pull request most recent head 3f9f759

Please upload reports for the commit 3f9f759 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #669       +/-   ##
===========================================
+ Coverage   84.62%   95.25%   +10.63%     
===========================================
  Files           3        2        -1     
  Lines         826      464      -362     
===========================================
- Hits          699      442      -257     
+ Misses        127       22      -105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -10,7 +10,7 @@ PackageCompiler is a Julia package with three main purposes:

2. Creating "apps" which are a bundle of files including an executable that can be sent and run on other machines without Julia being installed on that machine.

3. Creating a relocatable C library bundle form of Julia code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this seems correct.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand what it means but it must be me then 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought it was not clear either, but a second read it made sense. Maybe inversion helps clarity:

"Creating a relocatable bundle of Julia code in the form of a C library."

@sjkelly sjkelly closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants