Make implicit function definition (in julia_init.c) an error
#936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an easy thing to get wrong. Someone more familiar with Julia than with C is not likely to recognize the significance of this error. I've also almost never seen this intentionally ignored in the wild, so I don't expect many false positives.
|
fwiw, @gbaraldi would like to compile with I do like that hygiene, but it might need a flag since it's not uncommon to get warnings due to headers somewhat outside your control. |
I think |
sjkelly
approved these changes
Apr 4, 2024
|
Yeah, I agree - but let's tackle that in a separate PR to collect more input 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone more familiar with Julia than with C is not likely to recognize the significance of this error, but it's almost always a sign that you've built an object with a broken ABI somewhere.
I've also almost never seen this intentionally ignored in the wild, so I don't expect many false positives.