Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the Julia release banner with and without the slash #938

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Check the Julia release banner with and without the slash #938

merged 1 commit into from
Apr 30, 2024

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Apr 8, 2024 •
edited
Loading

We could instead do a regex, but this seemed simpler.

LilithHafner
LilithHafner approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@LilithHafner LilithHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #937, but this PR comments, so it wins.

@sjkelly sjkelly merged commit 791bc90 into master Apr 30, 2024
27 of 39 checks passed
@sjkelly sjkelly deleted the dpa/banner-slash branch April 30, 2024 14:04
@sjkelly
Copy link
Collaborator

sjkelly commented Apr 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilithHafner LilithHafner LilithHafner approved these changes

@fredrikekre fredrikekre Awaiting requested review from fredrikekre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DilumAluthge @sjkelly @LilithHafner