Let cond of an emtpy matrix return zero

Fixes #38327.
JuliaLang · Nov 10, 2020 · 4717d69 · 4717d69
1 parent 21c2c51
commit 4717d69
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/stdlib/LinearAlgebra/src/dense.jl b/stdlib/LinearAlgebra/src/dense.jl
@@ -1457,6 +1457,7 @@ Condition number of the matrix `M`, computed using the operator `p`-norm. Valid
 function cond(A::AbstractMatrix, p::Real=2)
     if p == 2
         v = svdvals(A)
+        isempty(v) && return zero(eltype(v))
         maxv = maximum(v)
         return iszero(maxv) ? oftype(real(maxv), Inf) : maxv / minimum(v)
     elseif p == 1 || p == Inf

diff --git a/stdlib/LinearAlgebra/test/dense.jl b/stdlib/LinearAlgebra/test/dense.jl
@@ -39,6 +39,11 @@ Random.seed!(1234321)
         M = [1.0 -2.0; -2.0 -1.5]
         @test cond(M, 1) ≈ 2.227272727272727
     end
+    @testset "Empty matrices" for p in (1, 2, Inf)
+        @test cond(zeros(Int, 0, 0), p) === 0.0
+        @test cond(zeros(0, 0), p) === 0.0
+        @test cond(zeros(ComplexF64, 0, 0), p) === 0.0
+    end
 end
 
 areal = randn(n,n)/2