Compiler: avoid type instability in access to PartialStruct field
#57553
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
force-pushed
the
Compiler_PartialStruct_undef_field_access
branch
from
f73a76a to
ab72c5f
Compare
using SnoopCompileCore
invs = @snoop_invalidations begin
struct I <: Integer end
Base.Int64(::I) = 7
end
display(length(invs)) # before: 5451, after: 2131 |
The `Base.getproperty` method for `PartialStruct` has a type assert to ensure type stable access of the field `undef`. However Compiler.jl has `Compiler.getproperty === Core.getfield`. Introduce a getter for this field of `PartialStruct` into Compiler.jl and use it. I guess this should improve compiler performance, and it should help avoid spurious invalidation.
nsajko
force-pushed
the
Compiler_PartialStruct_undef_field_access
branch
from
4c45fa3 to
105ffb9
Compare
Thanks!
That would be nice 😃 |
aviatesk
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Base.getpropertymethod forPartialStructhas a type assert to ensure type stable access of the fieldundef. However Compiler.jl hasCompiler.getproperty === Core.getfield.Introduce a getter for this field of
PartialStructinto Compiler.jl and use it.I guess this should improve compiler performance, and it should help avoid spurious invalidation.