Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler row/col length using row/colrange #433

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Mar 19, 2024

colrange and rowrange should be empty (i.e. having a length of 0) if there is no value in the column/row, so the max will be implicit.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (13b11fc) to head (da4b4d3).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   89.59%   87.76%   -1.84%     
==========================================
  Files          25       23       -2     
  Lines        3557     3130     -427     
==========================================
- Hits         3187     2747     -440     
- Misses        370      383      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 4c12ca3 into JuliaLinearAlgebra:master Mar 19, 2024
12 of 13 checks passed
@jishnub jishnub deleted the rowcollength branch March 19, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant