Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update CI pipeline #102

Merged
merged 1 commit into from
May 15, 2024
Merged

CI: Update CI pipeline #102

merged 1 commit into from
May 15, 2024

Conversation

barucden
Copy link
Member

@barucden barucden commented Apr 19, 2024

@barucden barucden marked this pull request as draft April 19, 2024 22:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (c884df6) to head (dcdb4b1).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   87.98%   89.86%   +1.88%     
==========================================
  Files           6        6              
  Lines         283      306      +23     
==========================================
+ Hits          249      275      +26     
+ Misses         34       31       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@barucden barucden marked this pull request as ready for review May 14, 2024 07:35
@barucden
Copy link
Member Author

I took the CI settings from LIBLINEAR.jl. Now, Codecov runs, and we also test x86 architectures.

The inclusion of x86 revealed a few tests that were too strict, so I added a tolerance there. Can you check, @ablaom, that it is all good?

Copy link
Contributor

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@barucden barucden merged commit ca39b63 into JuliaML:master May 15, 2024
10 checks passed
@barucden barucden deleted the ci branch May 15, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants