Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate DataLoader #92

Closed
wants to merge 1 commit into from
Closed

deprecate DataLoader #92

wants to merge 1 commit into from

Conversation

CarloLucibello
Copy link
Member

This is in case we decide to move the DataLoader to DataLoaders.jl (see discussion in #90)

@CarloLucibello CarloLucibello marked this pull request as draft May 29, 2022 10:08
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2022

Codecov Report

Merging #92 (422256c) into main (5e80fe6) will decrease coverage by 0.73%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   90.14%   89.41%   -0.74%     
==========================================
  Files          13       12       -1     
  Lines         487      425      -62     
==========================================
- Hits          439      380      -59     
+ Misses         48       45       -3     
Impacted Files Coverage Δ
src/eachobs.jl 96.42% <92.85%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e80fe6...422256c. Read the comment docs.

@CarloLucibello
Copy link
Member Author

closing this as we decided in #90 to keep the parallel option for the time being

@CarloLucibello CarloLucibello deleted the cl/nodataloader branch December 28, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants