Skip to content

Commit

Permalink
Remove DST prefix
Browse files Browse the repository at this point in the history
  • Loading branch information
@juliohm
juliohm committed Oct 18, 2024
1 parent d9b4e7e commit 34144fc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/StatsLearnModels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ using StatsBase: mode, mean
using ColumnSelectors: ColumnSelector, selector
using TableTransforms: StatelessFeatureTransform

import DataScienceTraits as DST
import TableTransforms: applyfeat, isrevertible

using DecisionTree: AdaBoostStumpClassifier, DecisionTreeClassifier, RandomForestClassifier
Expand Down
4 changes: 2 additions & 2 deletions src/models/nearestneighbors.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ function predict(fmodel::FittedModel{<:NearestNeighborsModel}, table)
end

function _checkoutput(::KNNClassifier, x)
if !(elscitype(x) <: DST.Categorical)
if !(elscitype(x) <: Categorical)
throw(ArgumentError("output column must be categorical"))
end
end

function _checkoutput(::KNNRegressor, x)
if !(elscitype(x) <: DST.Continuous)
if !(elscitype(x) <: Continuous)
throw(ArgumentError("output column must be continuous"))
end
end
Expand Down

2 comments on commit 34144fc

@juliohm
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/117576

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.3.4 -m "<description of version>" 34144fc13a4f12e83301fbebd581466cb83eb2c2
git push origin v0.3.4

Please sign in to comment.