Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FFLAS_FFPACK] New recipe #9661

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

laurentbartholdi
Copy link
Contributor

@laurentbartholdi laurentbartholdi commented Oct 21, 2024

This is a recipe for the FFLAS_FFPACK - Finite Field Linear Algebra Subroutines package.

It is based on Givaro (see Givaro_jll), and is part of the LinBox series of libraries. It is purely C++.

@laurentbartholdi laurentbartholdi deleted the laurentbartholdi-fflas branch October 21, 2024 18:49
@laurentbartholdi laurentbartholdi restored the laurentbartholdi-fflas branch October 21, 2024 18:50
@laurentbartholdi laurentbartholdi changed the title [FFLAS-FFPACK] New recipe [FFLAS_FFPACK] New recipe Oct 21, 2024
@laurentbartholdi
Copy link
Contributor Author

Hi @giordano , this is a dependency that I created out of my original attempt to have a binary package for the library Spasm. In particular, I'm working on a recipe for Spasm with a Dependency("FFLAS_FFPACK_jll"; compat="2.5.0") in it. For now, of course, this recipe fails because FFLAS_FFPACK is not yet merged; however, is there any way I can test my new recipe, to make sure that I cooked FFLAS_FFPACK correctly?

F/FFLAS_FFPACK/build_tarballs.jl Outdated Show resolved Hide resolved
F/FFLAS_FFPACK/build_tarballs.jl Outdated Show resolved Hide resolved
Comment on lines +38 to +41
# The products that we will ensure are always built
products = [
FileProduct("include/fflas-ffpack/fflas-ffpack-config.h", :fflas_ffpack_config_h)
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the product only a header file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is almost-pure C++ library, which produces lots of files, all in include/ except for a bin/fflas-ffpack-config. Should I include more?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After opening the archive and not seeing any binary product I believe the correct answer should have been: yes, this is a header-only package.

@laurentbartholdi
Copy link
Contributor Author

Dear @giordano , I believe I addressed all the points you raised. Is the correct procedure to wait for the formula to be merged, and hope that it works as expected for Spasm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants