Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function “reference()” to access a PhysicalConstant’s reference #37

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

Socob
Copy link
Contributor

@Socob Socob commented Oct 7, 2024

Not exported due to the potentially generic name, but I don’t think it necessarily needs to be.

Fixes #35.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.19%. Comparing base (72782d8) to head (6d1607e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #37       +/-   ##
===========================================
- Coverage   93.75%   77.19%   -16.56%     
===========================================
  Files           3        3               
  Lines          80       57       -23     
===========================================
- Hits           75       44       -31     
- Misses          5       13        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giordano
Copy link
Member

giordano commented Oct 7, 2024

Can you please add a test for this? Agreed not to export the generic name

@Socob
Copy link
Contributor Author

Socob commented Oct 8, 2024

Ah, I thought the doctest was enough. Maybe the doctests should be run as part of regular testing?

@giordano
Copy link
Member

giordano commented Oct 8, 2024

I prefer to have explicit tests besides doctests 🙂

@Socob
Copy link
Contributor Author

Socob commented Oct 8, 2024

It wouldn’t hurt having them run automatically in addition to other tests, though?

Either way, tests added!

@Socob
Copy link
Contributor Author

Socob commented Oct 8, 2024

No idea why Codecov thinks that codata2018.jl was covered 100% before and is now 0%…

@giordano giordano merged commit 097613c into JuliaPhysics:master Oct 8, 2024
12 of 14 checks passed
@Socob Socob deleted the add-reference-func branch October 8, 2024 09:15
@giordano
Copy link
Member

giordano commented Oct 8, 2024

Doctests are run as part of the documentation building, so they're still run and would fail the build in case something break anyways. But I like keeping tests self-sufficient, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access constant reference
2 participants