Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: UnfoldSim v0.2.0 #100272

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

- Breaking: simulate for `MultiSubjectDesign` now returns a 2Dinstead of the concatenated 1D matrix (or 3D instead of 2D in case of multichannel / `return_epoched`).  @jschepers together with @behinger. Note the following clarifications how noise is added to the signal:
  - If `return_epoched = true` and `onset =NoOnset()` the noise is added to the epoched data matrix
  - If `onset` is not `NoOnset`, a continuous eeg signal is created and the noise is added to this i.e. this means that the noise won't be the same as in the `onset = NoOnset()` case even if `return_epoched = true`.
  - The case `return_epoched = false` and `onset = NoOnset()` is not possible and therefore covered by an assert statement
- New Tutorial: Using already existing onsets @behinger
- New Reference: Onset distributions @jschepers 
- Empty `SingleSubjectDesign` now returns a design with a `Dummy` trial/condition, instead of throwing an error @behinger 
- much improved unittests @jschepers

UUID: ed8ae6d2-84d3-44c6-ab46-0baf21700804
Repo: https://github.com/unfoldtoolbox/UnfoldSim.jl.git
Tree: 40b4193f01277e1093b9980375bc530ffd726962

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit 5409f62 into master Feb 5, 2024
22 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-unfoldsim-ed8ae6d2-v0.2.0-711c034ea9 branch February 5, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants