Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: CoolPropCycles v0.1.0 #117882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Oct 23, 2024

## Breaking changes

- First set of Components for thermodynamic cycles

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

UUID: b01af851-7cff-425c-b4a4-ed45d3481e5c
Repo: https://github.com/Sush1090/CoolPropCycles.jl.git
Tree: f920ae1adfd4f1ceb7fb7701c51bcd96326d088b

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-coolpropcycles-b01af851-v0.1.0-7f771c95e0 branch from 79beb14 to e6c0367 Compare October 23, 2024 10:14
@goerz
Copy link
Member

goerz commented Oct 23, 2024

[noblock] Should this be part of the CoolProp org? @barche @jowr

@jowr
Copy link

jowr commented Oct 23, 2024

[noblock] It looks like it uses CoolProp, but it not directly related. We could mention it on the homepage, but it should most likely hasve its own repo and user base.

@goerz
Copy link
Member

goerz commented Oct 23, 2024

[noblock] Ok… the two reasons for tagging you was that (a) a CoolProp org/package has some say over packages CoolProp<Anything>, so I wanted you to be aware of this registration; and (b), if there's a possibility for a project to be hosted by an org rather than a personal account, that's always preferable, since it reduces the bus factor.

@jowr Please note that your comment is blocking. Can you edit it to contain [noblock]?

@jowr
Copy link

jowr commented Oct 23, 2024

[noblock] OK, I guess you have a point. However, I would prefer to have CoolProp focus on the fluid properties and not the modelling of thermal systems.

Thanks for the heads up with [noblock].

@Sush1090
Copy link

Sush1090 commented Oct 23, 2024

[noblock]

a CoolProp org/package has some say over packages CoolProp<Anything>, so I wanted you to be aware of this registration

@goerz @jowr Do I have to change the package name to avoid this?

@goerz
Copy link
Member

goerz commented Oct 23, 2024

Do I have to change the package name to avoid this?

No, not unless a CoolProp maintainer had a problem with this package (which they don't seem to have ;-) )

@Sush1090 Your comment is also blocking now. All comments have to contain [noblock]

@barche
Copy link
Contributor

barche commented Oct 24, 2024

Well, it's OK to block, since I think the package has to be renamed :)

I haven't had the chance yet to speak to @Sush1090 about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants