-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Bloqade & its components #59613
add Bloqade & its components #59613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cloned General, checked out this PR, then loaded each package successfully. Then I used Aqua.jl to check compat bounds existed. They all do. There were a few Aqua test failures, but none that would block AutoMerge. In case you're interested, they are the following (besides ambiguities). The unbound type parameters at least are worth fixing IMO.
just do
using BloqadeKrylov, Aqua, Test
@testset "" begin Aqua.test_all(BloqadeKrylov; ambiguities=false) end
for example.
BloqadeKrylov
Test Summary: | Pass Fail Total
| 3 4 7
Method ambiguity | No tests
Unbound type parameters | 1 1
Undefined exports | 1 1
Compare Project.toml and test/Project.toml | 1 1
BloqadeKrylov [bd27d05e-4cd1-5e79-84dd-c5d7d508ade2] | 1 1
Stale dependencies | 1 1
BloqadeKrylov [bd27d05e-4cd1-5e79-84dd-c5d7d508ade2] | 1 1
Compat bounds | 1 1
Project.toml formatting | 2 2
/Users/eph/.julia/packages/BloqadeKrylov/dC3FN/Project.toml | 1 1
/Users/eph/.julia/packages/BloqadeKrylov/dC3FN/test/Project.toml | 1 1
ERROR: Some tests did not pass: 3 passed, 4 failed, 0 errored, 0 broken.
BloqadeMIS
Test Summary: | Pass Fail Total
| 5 1 6
Method ambiguity | No tests
Unbound type parameters | 1 1
Undefined exports | 1 1
Compare Project.toml and test/Project.toml | 1 1
Stale dependencies | 1 1
BloqadeMIS [bd27d05e-4ce1-5e74-84dd-c5d7d508bbe2] | 1 1
Compat bounds | 1 1
Project.toml formatting | 1 1
ERROR: Some tests did not pass: 5 passed, 1 failed, 0 errored, 0 broken.
YaoSubspaceArrayReg
Test Summary: | Pass Fail Total
| 5 1 6
Method ambiguity | No tests
Unbound type parameters | 1 1
Undefined exports | 1 1
Compare Project.toml and test/Project.toml | 1 1
Stale dependencies | 1 1
Compat bounds | 1 1
Project.toml formatting | 1 1
/Users/eph/.julia/packages/YaoSubspaceArrayReg/BWKKo/Project.toml | 1 1
BloqadeLattices
Test Summary: | Pass Fail Total
| 5 1 6
Method ambiguity | No tests
Unbound type parameters | 1 1
Undefined exports | 1 1
Compare Project.toml and test/Project.toml | 1 1
Stale dependencies | 1 1
Compat bounds | 1 1
Project.toml formatting | 1 1
ERROR: Some tests did not pass: 5 passed, 1 failed, 0 errored, 0 broken.
BloqadeODE
Test Summary: | Pass Fail Total
| 3 3 6
Method ambiguity | No tests
Unbound type parameters | 1 1
Undefined exports | 1 1
Compare Project.toml and test/Project.toml | 1 1
Stale dependencies | 1 1
BloqadeODE [bd27d05e-4ce1-5e79-84dd-c5d7d508bbe5] | 1 1
Compat bounds | 1 1
Project.toml formatting | 1 1
/Users/eph/.julia/packages/BloqadeODE/aUw9S/Project.toml | 1 1
ERROR: Some tests did not pass: 3 passed, 3 failed, 0 errored, 0 broken.
thanks for helping with the registration! and thanks for reminding me of the Aqua tests, they are quite helpful! Indeed, I'm thinking to add Aqua afterward, despite some of our dependencies having quite serious ambiguities to be fixed, lol |
Personally I often just use |
coming from slack would be nice if this could get merged since I already had
BloqadeExpr
waited 3 days...