Relax Fill return type in mvlognormal tests #1890
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JuliaArrays/FillArrays.jl#385 I'm working on improving how broadcasting works for FillArrays. One of the changes is that some types may be inferred differently, so e.g.
Currently
Proposed:
Currently, in one of the
mvlognormal
tests, this package is explicitly checking for aFill
. This PR relaxes this to aUnion{Fill, Ones}
so that the tests pass either way.