Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset m.optsum.feval in prfit! to show model has been fit #800

Closed
wants to merge 2 commits into from

Conversation

dmbates
Copy link
Collaborator

@dmbates dmbates commented Jan 22, 2025

  • The prfit! method did not reset m.optsum.feval so the model was not recognized as having been fit.
  • We should discuss how far we want to go in modifying m.optsum within prfit!.

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@dmbates dmbates marked this pull request as draft January 22, 2025 17:53
@dmbates dmbates requested a review from palday January 22, 2025 17:53
@palday
Copy link
Member

palday commented Jan 22, 2025

@dmbates woops I didn't see this and just opened #801

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.27%. Comparing base (3f81dc2) to head (ba8928a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files          35       35           
  Lines        3409     3410    +1     
=======================================
+ Hits         3316     3317    +1     
  Misses         93       93           
Flag Coverage Δ
current 96.91% <100.00%> (+<0.01%) ⬆️
minimum 97.27% <100.00%> (+<0.01%) ⬆️
nightly 96.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmbates
Copy link
Collaborator Author

dmbates commented Jan 22, 2025

No problem. We can close this PR as #801 is more thorough.

@dmbates dmbates closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants