Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v 9.0 #150

Merged
merged 495 commits into from
Oct 23, 2024
Merged

v 9.0 #150

merged 495 commits into from
Oct 23, 2024

Conversation

juandelperal
Copy link
Collaborator

This version is a big update.

  • We are introducing a new subfamily: Montserrat Underline, which is the new version and replacement of Montserrat Subrayada
  • Includes many African languages (SSA)
  • Improvements for the building pipeline and testing.
  • Many other improvements and character extension growth 2731 vs 1968 glyphs

@juandelperal
Copy link
Collaborator Author

Hi @m4rc1e
After merging, I fixed some problems with the building pipeline and the config yamls (latests commits).
Still, after make build I find many files that shouldn't be there:

+sources/.ninja_log
+sources/build.ninja
+sources/instance_ufos/

Is there something wrong in the pipeline? should we .gititnore them?

@m4rc1e
Copy link
Contributor

m4rc1e commented Oct 4, 2024

Looks like something wrong in gftools builder. I'll make a fix.

@kenmcd
Copy link

kenmcd commented Oct 16, 2024

There is an issue in the static ThinItalic fonts affecting the uppercase U.
It appears to be broken.
And not all of the composites are the same.

Montserrat-ThinItalic.otf
Montserrat-ThinItalic.ttf
The VF Italic seems to be fine.

Maybe something in the build process is causing this.

Static ThinItalic U

Static ThinItalic U composites

@juandelperal
Copy link
Collaborator Author

Thanks @kenmcd will review it

@juandelperal
Copy link
Collaborator Author

We updated the first point of the shape in case that was the problem, but it didn't work
It seems though that it's related to gftools builder. Comparison:

Built using gftools
Screenshot 2024-10-17 at 10 55 22

Exported directly from Glyphs
Screenshot 2024-10-17 at 10 55 17

It only happens with U, not with similar shapes /W.ss01/U.ss01
Screenshot 2024-10-17 at 10 59 23

cc @m4rc1e

@m4rc1e
Copy link
Contributor

m4rc1e commented Oct 17, 2024

Thanks @kenmcd. This appears to be an issue in fontmake. It seems that the overlap removal step is causing the issue.

@m4rc1e
Copy link
Contributor

m4rc1e commented Oct 17, 2024

@juandelperal got a fix. In the config.yaml, add the following extraStaticFontmakeArgs: "--overlaps-backend pathops"

Screenshot 2024-10-17 at 10 56 57

@juandelperal
Copy link
Collaborator Author

it worked!
Now it should be fixed @kenmcd

Thanks @m4rc1e

@m4rc1e
Copy link
Contributor

m4rc1e commented Oct 18, 2024

Is there anything else we need to do in order to get this released? I think we're going to ignore the bracket layers and INDD issue for this release.

@juandelperal
Copy link
Collaborator Author

I added a known issues section to the readme mentioning these bugs.
Thanks a lot @m4rc1e

@juandelperal juandelperal merged commit 0edaf9f into master Oct 23, 2024
2 checks passed
@juandelperal juandelperal deleted the merge-forked-changes branch October 23, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants