Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor user storage, change picture to bytes type #104

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

JurgenR
Copy link
Owner

@JurgenR JurgenR commented Nov 6, 2023

Closes #103
Closes #82
Adds upload_permissions to user info reply ( for #79 )

Copy link

github-actions bot commented Nov 6, 2023

Test Results

       8 files  ±  0         8 suites  ±0   40s ⏱️ -1s
   594 tests  -   7     594 ✔️  -   7  0 💤 ±0  0 ±0 
4 752 runs   - 56  4 752 ✔️  - 56  0 💤 ±0  0 ±0 

Results for commit 5a93de4. ± Comparison against base commit d88f1cd.

This pull request removes 13 and adds 6 tests. Note that renamed tests count towards both.
tests.unit.room.test_room_model.TestModelRoom ‑ test_addMember_memberDoesNotExist_shouldAdd
tests.unit.room.test_room_model.TestModelRoom ‑ test_addMember_memberExists_shouldNotAdd
tests.unit.room.test_room_model.TestModelRoom ‑ test_addOperator_operatorDoesNotExist_shouldAdd
tests.unit.room.test_room_model.TestModelRoom ‑ test_addOperator_operatorExists_shouldNotAdd
tests.unit.room.test_room_model.TestModelRoom ‑ test_removeMember_memberDoesNotExist_shouldDoNothing
tests.unit.room.test_room_model.TestModelRoom ‑ test_removeMember_memberExists_shouldRemove
tests.unit.room.test_room_model.TestModelRoom ‑ test_removeOperator_operatorDoesNotExist_shouldDoNothing
tests.unit.room.test_room_model.TestModelRoom ‑ test_removeOperator_operatorExists_shouldRemove
tests.unit.user.test_user_manager.TestUserManager ‑ test_getOrCreateUser_existingUserByName_shouldReturnUser
tests.unit.user.test_user_manager.TestUserManager ‑ test_getOrCreateUser_existingUserByObject_shouldReturnUser
…
tests.unit.protocol.test_messages.TestPeerUserInfoReply ‑ test_PeerUserInfoReply_Request_deserialize_withPictureWithPermissions
tests.unit.protocol.test_messages.TestPeerUserInfoReply ‑ test_PeerUserInfoReply_Request_deserialize_withoutPictureWithPermissions
tests.unit.protocol.test_messages.TestPeerUserInfoReply ‑ test_PeerUserInfoReply_Request_serialize_withPictureWithPermissions
tests.unit.protocol.test_messages.TestPeerUserInfoReply ‑ test_PeerUserInfoReply_Request_serialize_withoutPictureWithPermissions
tests.unit.user.test_user_manager.TestUserManager ‑ test_getUserObject_existingUserByName_shouldReturnUser
tests.unit.user.test_user_manager.TestUserManager ‑ test_getUserObject_missingUserByName_shouldCreateAndReturnUser

♻️ This comment has been updated with latest results.

@JurgenR JurgenR merged commit 3781bc2 into main Nov 6, 2023
10 checks passed
@JurgenR JurgenR deleted the feat/refactor-user-storage branch November 28, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users: Refactor user storage Messages / Settings: picture should be bytes object
1 participant