Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set default parameters when adding a new waypoint #25

Merged
merged 1 commit into from
Oct 29, 2024
Merged

set default parameters when adding a new waypoint #25

merged 1 commit into from
Oct 29, 2024

Conversation

Yutarop
Copy link
Collaborator

@Yutarop Yutarop commented Oct 29, 2024 •
edited
Loading

PR Type

  • Feature
  • Bug fix
  • Refactor
  • Documentation
  • Other

Overview

  • Waypoints Managerにおいて、新たにwaypointを追加する際に、デフォルトの設定として「vel」に1.0、「rad」に1.0、「stop」にfalseのパラメーターが自動的に適用されるよう変更を加えました。

Detail

  • Waypoints ManagerのGUIを管理するmanager_GUI.pyに変更を加えました。

Test

  • 実際にWaypoints Managerを立ち上げ、デフォルトで値が入っていることを確認しました。

Attention

@Yutarop Yutarop requested review from shunsugar and kugurofu October 29, 2024 06:03
@Yutarop Yutarop self-assigned this Oct 29, 2024
shunsugar
shunsugar approved these changes Oct 29, 2024
View reviewed changes
Copy link

@shunsugar shunsugar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。とても助かります。

@shunsugar shunsugar merged commit db041ef into humble-devel Oct 29, 2024
6 checks passed
@shunsugar shunsugar deleted the feature/add_default_values branch October 29, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shunsugar shunsugar shunsugar approved these changes

@kugurofu kugurofu Awaiting requested review from kugurofu

Assignees

@Yutarop Yutarop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yutarop @shunsugar