Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add desktopFileName static methods to QGuiApplication #1087

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

dphaldes
Copy link
Contributor

@dphaldes dphaldes commented Oct 4, 2024

Added methods :

fn set_desktop_file_name(name: &QString);
fn desktop_file_name() -> QString;

This is required to set the application desktop name association on Linux. This allows desktop entries and taskbar icons.
Example:
image

Example usage: https://github.com/mystchonky/kontrast-rs/blob/54ace175a97f044c714599bcbf645e95a766c8a0/src/main.rs#L14

@dphaldes
Copy link
Contributor Author

dphaldes commented Oct 4, 2024

I have tried to follow the code structure/organization. I can move the functions around if something else is more suitable

Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mystchonky ,

Thank you for the contribution. The change looks good 😊

@LeonMatthesKDAB LeonMatthesKDAB enabled auto-merge (squash) October 4, 2024 07:12
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dff128f) to head (8e26aaa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1087   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines        11928     11928           
=========================================
  Hits         11928     11928           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeonMatthesKDAB LeonMatthesKDAB merged commit ff27740 into KDAB:main Oct 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants