WIP: examples: create a multi project to test multiple crates #598

ahayzen-kdab · 2023-06-28T17:39:26Z

No description provided.

examples/meta_project/rust/sub1/Cargo.toml

Be-ing · 2023-06-28T17:57:29Z

Be-ing · 2023-07-03T19:30:30Z

Upstream PR to make this work: rust-lang/rust#113301

Be-ing · 2023-09-29T18:22:56Z

The upstream PR has been merged and will be released in stable Rust 1.74, which is scheduled for 16 November 2023. I suggest to leave this as a draft until then.

ahayzen-kdab · 2023-10-02T08:23:17Z

@Be-ing Awesome news, thanks! :-)

Be-ing · 2023-11-16T16:55:56Z

Rust 1.74 has been released so this now builds with stable Rust! 🥳

ahayzen-kdab · 2023-11-16T17:11:42Z

@Be-ing sweet! Great work on getting that stabilised into Rust 💪 We look at getting this landed and the reshuffle internally in the next cycle I think as 0.6 is imminent with a deadline we need to reach.

ahayzen-kdab · 2023-11-24T13:37:57Z

Seems to be getting a linking issue with double resources, need to investigate. Wonder if it's the QML module changes.

Be-ing · 2023-11-25T06:19:32Z

Seems to be getting a linking issue with double resources, need to investigate. Wonder if it's the QML module changes.

Fixed in #755

ahayzen-kdab · 2023-11-27T11:52:51Z

Locally this builds now, but it fails to run as it can't find the sub QML QObjects, needs some further investigation or maybe a clean build.

Be-ing · 2023-11-27T19:16:15Z

I can reproduce that. nm -C build/examples/meta_project/example_meta_project|grep cxx_qt_demo_sub1 shows that the symbols for registering the QML type do end up in the executable... so why aren't they working? 🤔

Be-ing · 2023-11-29T07:05:17Z

I opened a PR for your fork to get this working: ahayzen-kdab#4 The errors were simply from missing #[qml_element] attributes :)

ahayzen-kdab · 2023-11-29T08:08:02Z

I opened a PR for your fork to get this working: ahayzen-kdab#4 The errors were simply from missing #[qml_element] attributes :)

Aha! great spot thanks!

ahayzen-kdab · 2023-11-29T09:58:58Z

Seems macOS works, Windows has had a wobble with file locking / mapped stuff, Linux explodes using ld.gold.

Is this one of those, only lld works situations ?

Be-ing · 2023-11-29T10:07:45Z

Seems we're continuing the CXX-Qt tradition of stumbling over the weirdest edge cases of toolchains 😅

Somehow Cargo does specify linking the same qt-static-initializers library twice with --whole-archive, so it makes sense why gold fails... but why does Cargo do that? And only does that for cargo test?? Perhaps a Cargo bug?

As for the Windows Qt5 build error:

 error: failed to write file '\\?\C:\cxx-qt\build\cargo\build\x86_64-pc-windows-msvc\release\deps\libsub1-ef2617c41816f8ec.rlib': The requested operation cannot be performed on a file with a user-mapped section open. (os error 1224)

I don't know. Another cargo/rustc bug? A Windows bug? I don't see this error code anywhere in any rust-lang GitHub repositories.

A quick hack around both of these problems would be replacing the --all-targets CLI option to cargo test in the root CMakeLists.txt with --workspace --exclude qml-meta-project. The qml-meta-project crate doesn't even have Cargo tests, so there's not much point building it in that context.

ahayzen-kdab · 2023-11-29T10:09:45Z

Seems we're continuing the CXX-Qt tradition of stumbling over the weirdest edge cases of toolchains 😅

😅

Yeah, a switch around to ensure it builds (and maybe runs) would be useful, I'll probably look into this next month as I'm tight on time.

Be-ing · 2023-11-29T10:11:43Z

I don't think it's worth deep diving into the root causes of these errors right now considering that qml-meta-project doesn't even have Cargo tests. So I think switching to --workspace --exclude qml-meta-project would be sufficient for finally merging this PR.

Be-ing · 2023-12-01T08:50:50Z

Hopefully this will be enough to merge finally: ahayzen-kdab#5

ahayzen-kdab · 2024-01-17T12:00:31Z

Split only running cachegen when there are QML files in #811

ahayzen-kdab · 2024-01-18T10:24:06Z

Wonder if it's the Rust side that needs to not be parallel rather than the C++/CMake side, but still shouldn't happen.

The `increment` methods of the subobjects are invoked from QML, so don't also invoke them from Rust. This also makes the behavior of the application clearer: Main counts by 1, Sub1 counts by 2, Sub2 counts by 3.

This isn't required for the libraries published to crates.io, so this isn't specified in the workspace Cargo.toml.

No need to change the privacy of these; just need to have the symbols referenced within the staticlib crate.

ahayzen-kdab · 2024-10-08T16:15:19Z

This will need further work and changes for the way QML modules are now passed around and as part of the 0.8 cycle improvements where a single crate could become a QML module.

codecov · 2024-10-08T16:17:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7d57542) to head (0530e1a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #598   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines        11953     11953           
=========================================
  Hits         11953     11953

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ahayzen-kdab commented Jun 28, 2023

View reviewed changes

examples/meta_project/rust/sub1/Cargo.toml Outdated Show resolved Hide resolved

This was referenced Jun 28, 2023

figure out and document how to link multiple cxx-qt modules into an application #148

Open

cxx-qt-lib: use +whole_archive for std_types so that cargo-only works #593

Merged

Tracking Issue for feature(packed_bundled_libs) rust-lang/rust#108081

Open

ahayzen-kdab force-pushed the 592-multi-crate-project branch from b3a1337 to 4f929ab Compare June 29, 2023 08:46

Be-ing mentioned this pull request Aug 15, 2023

stabilize combining +bundle and +whole-archive link modifiers rust-lang/rust#113301

Merged

ahayzen-kdab force-pushed the 592-multi-crate-project branch 2 times, most recently from a402176 to 5979009 Compare August 16, 2023 08:11

ahayzen-kdab force-pushed the 592-multi-crate-project branch from 5979009 to aac8317 Compare November 24, 2023 12:20

Be-ing mentioned this pull request Nov 25, 2023

qt-build-utils: use QML module name in .qrc file name #755

Merged

ahayzen-kdab force-pushed the 592-multi-crate-project branch from aac8317 to b144bd0 Compare November 27, 2023 10:24

ahayzen-kdab force-pushed the 592-multi-crate-project branch from 29127a1 to 2420d45 Compare November 29, 2023 09:24

Be-ing mentioned this pull request Nov 29, 2023

book: document splitting a project into crates #763

Draft

LeonMatthesKDAB mentioned this pull request Dec 15, 2023

CXX-Qt-lib-extra #766

Open

ahayzen-kdab force-pushed the 592-multi-crate-project branch 2 times, most recently from db75055 to 3f47566 Compare January 15, 2024 15:11

ahayzen-kdab and others added 6 commits October 8, 2024 17:11

examples: create a multi project to test multiple crates

61a9291

meta_project: add missing #[qml_element] attributes

7a99575

meta_project: update build system to new practices

c3e13ec

meta_project: don't double invoke increment methods

d0fe61a

The `increment` methods of the subobjects are invoked from QML, so don't also invoke them from Rust. This also makes the behavior of the application clearer: Main counts by 1, Sub1 counts by 2, Sub2 counts by 3.

meta_project: specify and document Rust 1.74 MSRV

2353a8f

This isn't required for the libraries published to crates.io, so this isn't specified in the workspace Cargo.toml.

meta_project: use extern crate rather than pub use

0530e1a

No need to change the privacy of these; just need to have the symbols referenced within the staticlib crate.

ahayzen-kdab force-pushed the 592-multi-crate-project branch from 3f47566 to 0530e1a Compare October 8, 2024 16:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: examples: create a multi project to test multiple crates #598

WIP: examples: create a multi project to test multiple crates #598

ahayzen-kdab commented Jun 28, 2023

Be-ing commented Jun 28, 2023

Be-ing commented Jul 3, 2023

Be-ing commented Sep 29, 2023

ahayzen-kdab commented Oct 2, 2023

Be-ing commented Nov 16, 2023

ahayzen-kdab commented Nov 16, 2023

ahayzen-kdab commented Nov 24, 2023

Be-ing commented Nov 25, 2023

ahayzen-kdab commented Nov 27, 2023

Be-ing commented Nov 27, 2023

Be-ing commented Nov 29, 2023

ahayzen-kdab commented Nov 29, 2023

ahayzen-kdab commented Nov 29, 2023

Be-ing commented Nov 29, 2023 •

edited

Loading

ahayzen-kdab commented Nov 29, 2023

Be-ing commented Nov 29, 2023

Be-ing commented Dec 1, 2023

ahayzen-kdab commented Jan 17, 2024

ahayzen-kdab commented Jan 18, 2024

ahayzen-kdab commented Oct 8, 2024

codecov bot commented Oct 8, 2024

WIP: examples: create a multi project to test multiple crates #598

Are you sure you want to change the base?

WIP: examples: create a multi project to test multiple crates #598

Conversation

ahayzen-kdab commented Jun 28, 2023

Be-ing commented Jun 28, 2023

Be-ing commented Jul 3, 2023

Be-ing commented Sep 29, 2023

ahayzen-kdab commented Oct 2, 2023

Be-ing commented Nov 16, 2023

ahayzen-kdab commented Nov 16, 2023

ahayzen-kdab commented Nov 24, 2023

Be-ing commented Nov 25, 2023

ahayzen-kdab commented Nov 27, 2023

Be-ing commented Nov 27, 2023

Be-ing commented Nov 29, 2023

ahayzen-kdab commented Nov 29, 2023

ahayzen-kdab commented Nov 29, 2023

Be-ing commented Nov 29, 2023 • edited Loading

ahayzen-kdab commented Nov 29, 2023

Be-ing commented Nov 29, 2023

Be-ing commented Dec 1, 2023

ahayzen-kdab commented Jan 17, 2024

ahayzen-kdab commented Jan 18, 2024

ahayzen-kdab commented Oct 8, 2024

codecov bot commented Oct 8, 2024

Codecov Report

Be-ing commented Nov 29, 2023 •

edited

Loading