Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cxx-qt-gen: remove qobject:: from impl a trait for a qobject in a bridge #613

Merged
merged 1 commit into from
Jul 18, 2023
Merged

cxx-qt-gen: remove qobject:: from impl a trait for a qobject in a bridge #613

merged 1 commit into from
Jul 18, 2023

Conversation

ahayzen-kdab
Copy link
Collaborator

Related to #559

@ahayzen-kdab ahayzen-kdab mentioned this pull request Jul 18, 2023
Merged
Be-ing
Be-ing approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seems like some magical scoping to have the type alias declared in the extern "RustQt" block but the trait outside of that 🤔 But anyway getting rid of the old qobject:: is an improvement.

@Be-ing Be-ing merged commit 8652992 into KDAB:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahayzen-kdab @Be-ing