Skip to content

Commit

Permalink
Utilize typed namedtuple instead of comments clarifying the type
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielZhangDP committed Sep 14, 2024
1 parent 3ad4071 commit 9ac3f86
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions cfmtoolbox/plugins/one_wise_sampling.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import random
from collections import defaultdict
from dataclasses import asdict
from typing import NamedTuple

import typer

Expand Down Expand Up @@ -133,11 +134,12 @@ def get_random_cardinality(self, cardinality_list: Cardinality):
def generate_random_children_with_random_cardinality_with_assignment(
self, feature: Feature
):
ChildAndCardinalityPair = NamedTuple(
"ChildAndCardinalityPair", [("child", Feature), ("cardinality", int)]
)
summed_random_instance_cardinality = 0
summed_random_group_type_cardinality = 0
child_with_random_instance_cardinality: list[
tuple[Feature, int]
] = [] # List of tuples (child, random_instance_cardinality)
child_with_random_instance_cardinality: list[ChildAndCardinalityPair] = []

for child in feature.children:
# Enforces the feature of the chosen assignment to have the chosen amount of instances
Expand All @@ -151,7 +153,7 @@ def generate_random_children_with_random_cardinality_with_assignment(
summed_random_group_type_cardinality += 1
summed_random_instance_cardinality += random_instance_cardinality
child_with_random_instance_cardinality.append(
(child, random_instance_cardinality)
ChildAndCardinalityPair(child, random_instance_cardinality)
)

return (
Expand Down

0 comments on commit 9ac3f86

Please sign in to comment.