Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uvl export #15

Merged
merged 7 commits into from
Sep 10, 2024
Merged

Add uvl export #15

merged 7 commits into from
Sep 10, 2024

Conversation

Aonokishi
Copy link
Collaborator

No description provided.

DoctorJohn
DoctorJohn requested changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@DoctorJohn DoctorJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty solid implementation! Needs some refactoring, but nothing too major.

cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
tests/plugins/test_uvl_export.py Show resolved Hide resolved
tests/plugins/test_uvl_export.py Outdated Show resolved Hide resolved
cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
@Aonokishi Aonokishi requested a review from DoctorJohn September 7, 2024 15:33
DoctorJohn
DoctorJohn requested changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@DoctorJohn DoctorJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent adjustments, almost good to go. I left some minor final comments/suggestions.

cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
cfmtoolbox/plugins/uvl_export.py Show resolved Hide resolved
cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
cfmtoolbox/plugins/uvl_export.py Outdated Show resolved Hide resolved
@Aonokishi @DoctorJohn
Improve readability
18798a5 
Co-authored-by: Jonathan Ehwald <[email protected]>
@Aonokishi Aonokishi requested a review from DoctorJohn September 9, 2024 00:38
DoctorJohn
DoctorJohn approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@DoctorJohn DoctorJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, you deserve all the internet points.

@Aonokishi Aonokishi merged commit c45fd2b into main Sep 10, 2024
3 checks passed
@Aonokishi Aonokishi deleted the uvl-export branch September 11, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoctorJohn DoctorJohn DoctorJohn approved these changes

@DanielZhangDP DanielZhangDP DanielZhangDP left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aonokishi @DoctorJohn @DanielZhangDP