Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated add_child method #29

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

DoctorJohn
Copy link
Collaborator

This was removed because it was essentially implementing set-like features on top of a list (i.e., using a set would have been easier). That being said, neither this approach nor using a set would currently work because of the recursive nature of the Feature model. To make things work, we would have to add a custom __eq__ method to the Feature model. But it looks like we don't need this behavior at all, so let's remove it.

@DoctorJohn DoctorJohn merged commit b75d876 into main Sep 13, 2024
3 checks passed
@DoctorJohn DoctorJohn deleted the deprecate-add-child-method branch September 13, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants