Skip to content

Commit

Permalink
Merge #1447: New dependencies of upgrading mods better handled by GUI
Browse files Browse the repository at this point in the history
* Postremus/#795:
  Add dependencies we are installing for a upgrade of a mod to the changeset fixes #795
  • Loading branch information
pjf committed Sep 27, 2015
2 parents 90a2058 + 5b526f3 commit 5f8898b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ All notable changes to this project will be documented in this file.
- [GUI] Installing a `.ckan` virtual mod will crash the client with an NRE less often (Postremus, #1478)
- [GUI] The "Installing mods" tab is now called the "Status log" tab, as it's used for upgrading and removing mods too. (plague006, #1460)
- [GUI] Links to `ckan://` resources under Linux are more likely to be handled correctly. (Postremus, #1434)
- [GUI] Mods upgrades with additional dependencies are better handled and displayed to the user. (Postremus, #1447)

### Features

Expand Down
3 changes: 1 addition & 2 deletions GUI/MainModList.cs
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ public async Task<IEnumerable<ModChange>> ComputeChangeSetFromModList(
{
case GUIModChangeType.None:
break;
case GUIModChangeType.Update:
case GUIModChangeType.Install:
//TODO: Fix
//This will give us a mod with a wrong version!
Expand All @@ -373,8 +374,6 @@ public async Task<IEnumerable<ModChange>> ComputeChangeSetFromModList(
case GUIModChangeType.Remove:
modules_to_remove.Add(change.Mod);
break;
case GUIModChangeType.Update:
break;
default:
throw new ArgumentOutOfRangeException();
}
Expand Down

0 comments on commit 5f8898b

Please sign in to comment.