Support multiple remote versions #3036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dealing with remote version info replacing local
If the root element is an array, look for exactly one matching version This will be used by AVC to determine the newest version for your KSP version. For NetKAN's purpose we just need the matching version.
|
AVC equivalent (needs to be rebased): linuxgurugamer/KSPAddonVersionChecker#35 |
HebaruSan
added
Enhancement
|
Pretty cool! Thanks for the PR. |
|
We'll probably need an update for KSP-AVC krefs as well in case ExtraplanetaryLaunchpads, EarlyBird, or CustomBulkheadProfiles decides to take advantage of this, see #2517. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used by AVC to determine the newest version for your KSP version. For NetKAN's purpose we just need the matching version.