Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CommandLineParser #3131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Olympic1
Copy link
Member

@Olympic1 Olympic1 commented Aug 5, 2020

Updated our CLI and NetKAN to use the latest version of CommandLineParser.

I had to change so much to the CLI that I mostly rewrote it. The functions mostly stayed the same, just a lot of renamings.

Changes:

  • Updated CommandLineParser to 2.8.0
  • Moved the Exit class into Core so it could be used by the CLI, NetKAN, and Tests (still working on the latter one)
  • Moved NoGameInstanceKraken into Kraken class (Core)
  • Moved the verbs (commands) into its respective file
  • Added docs to all public / internal functions
  • Added / Updated CLI messages to be more informative to the user
  • Removed ProgessReporter.cs as this was wasn't used anymore

Notes

  • Because of the way CommandLineParser now works, every command has to be parsed as an object
  • Also have to pass every list of strings as an IEnumerable
  • Needed to add a little hack to get the GUI to work, apparantly the arguments get lost somewhere passing over to GUI.Main_ -> Main.Main -> Main.OnLoad

Other

  • The next release of CommandLineParser will introduce aliases

@Olympic1 Olympic1 added Enhancement New features or functionality Cmdline Issues affecting the command line Pull request Netkan Issues affecting the netkan data labels Aug 5, 2020
@Olympic1 Olympic1 added the In progress We're still working on this label Nov 24, 2020
@Olympic1 Olympic1 force-pushed the feature/CommandLineParser branch 2 times, most recently from 7eb554d to f57c56e Compare January 12, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmdline Issues affecting the command line Enhancement New features or functionality In progress We're still working on this Netkan Issues affecting the netkan data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants