Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conflicts with WildBlue play modes' provided names #10256

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

HebaruSan
Copy link
Member

While wokring on the relationship resolver refactor for KSP-CKAN/CKAN#4108, I noticed that the WildBlue play modes and Heisenberg play modes conflicted with the identifiers they provide, but the other mod-specific play modes don't. This is inconsistent and probably makes the resolver work a bit harder to figure these out.

Now all of the play modes conflict with the identifiers they provide.
In addition, "Heisenberg" is replaced by "Airships" in the play mode names for consistency with the main mod.

@HebaruSan
Copy link
Member Author

Installing Airships Classic Stock Play Mode v2.19.2
  Error: 5787 [1] ERROR CKAN.CmdLine.ConsoleUser (null) - Inconsistencies were found:
  * CommunityResourcePack v112.0.1 (needed for: Heisenberg-PlayMode-ClassicStock v2.19.2) conflicts with WildBlue-PlayMode-ClassicStock v1.90.3 (needed for: Heisenberg-PlayMode-ClassicStock v2.19.2)
  Install canceled. Your files have been returned to their initial state.
  INFO:root:Dummy game instance deleted
  ERROR:root:Install of .ckans/Heisenberg-PlayMode-ClassicStock-v2.19.2.ckan failed!

I don't know why CRP is being pulled in as a dependency of Heisenberg-PlayMode-ClassicStock. When I try it in GUI, I get a redundant prompt to choose the WildBlue play mode, which of course only works if I choose the classic stock option, but then the install succeeds. Since we're not changing the relationships for Heisenberg, I'm going to chalk this up to quirks of the headless relationship resolver and merge.

image

@HebaruSan HebaruSan merged commit 3d6dfde into KSP-CKAN:master Oct 14, 2024
1 check failed
@HebaruSan HebaruSan deleted the fix/playmode-conflicts branch October 14, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant