Fix decouplers not having mass on initial placement. Allow decouplers…

… to use PF-style mass
KSP-RO · Sep 30, 2023 · 28e67f9 · 28e67f9
1 parent b175864
commit 28e67f9
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/Source/DecouplerTweaker.cs b/Source/DecouplerTweaker.cs
@@ -60,12 +60,21 @@ public class DecouplerTweaker : PartModule, IPartMassModifier
         [KSPField(isPersistant = true, guiActiveEditor = true, guiName="Mass", guiUnits="T", guiFormat="F3", groupName = ProceduralPart.PAWGroupName)]
         public float mass = 0;
 
+        [KSPField]
+        public bool usePFMass = false;
+        [KSPField]
+        public Vector4 specificMass = new Vector4(0.0002f, 0.0075f, 0.005f, 0f);
+        [KSPField]
+        public float decouplerMassMult = 4f;
+
         private ModuleDecouple decouple;
         internal const float ImpulsePerForceUnit = 0.02f;
+        private ProceduralPart procPart;
 
         public override void OnStart(StartState state)
         {
             decouple = part.FindModuleImplementing<ModuleDecouple>();
+            procPart = part.FindModuleImplementing<ProceduralPart>();
             if (decouple == null)
             {
                 Debug.LogError($"[ProceduralParts] No ModuleDecouple found on {part}");
@@ -92,6 +101,16 @@ public override void OnStart(StartState state)
             }
         }
 
+        public override void OnStartFinished(StartState state)
+        {
+            base.OnStartFinished(state);
+            if (HighLogic.LoadedSceneIsEditor && mass == 0f && density > 0)
+            {
+                if (procPart != null)
+                    UpdateMass(procPart.Volume);
+            }
+        }
+
         public void OnDestroy() => GameEvents.onTimeWarpRateChanged.Remove(OnTimeWarpRateChanged);
 
         private bool updatingTimeWarp = false;
@@ -142,10 +161,25 @@ private float CalcMaxImpulse(float diam, float min)
         public void OnPartVolumeChanged(BaseEventDetails data)
         {
             if (HighLogic.LoadedSceneIsEditor && density > 0 && data.Get<double>("newTotalVolume") is double volume)
+            {
+                UpdateMass(volume);
+            }
+        }
+
+        private void UpdateMass(double volume)
+        {
+            if (usePFMass && procPart != null)
+            {
+                float diam = procPart.Diameter;
+                float baseMass = (((((specificMass.x * diam) + specificMass.y) * diam) + specificMass.z) * diam) + specificMass.w;
+                mass = baseMass * decouplerMassMult;
+                mass *= Mathf.Lerp(0.9f, 1.1f, Mathf.InverseLerp(0.1f, 0.3f, procPart.Length / diam));
+            }
+            else
             {
                 mass = Convert.ToSingle(density * volume);
-                GameEvents.onEditorShipModified.Fire(EditorLogic.fetch.ship);
             }
+            GameEvents.onEditorShipModified.Fire(EditorLogic.fetch.ship);
         }
     }
 }
diff --git a/Source/ProceduralPart.cs b/Source/ProceduralPart.cs
@@ -31,6 +31,8 @@ public class ProceduralPart : PartModule, IPartCostModifier, IPartMassModifier
         private static bool staticallyResetPartUpgrades = false;
         public bool TUEnabled => installedTU && part.GetComponent("KSPTextureSwitch") is Component;
         public float Volume => CurrentShape.Volume;
+        public float Diameter => CurrentShape.MaxDiameter;
+        public float Length => CurrentShape.Length;
 
         [KSPField] public float diameterMax = float.PositiveInfinity;
         [KSPField] public float lengthMax = float.PositiveInfinity;