Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cause
The SQL column has a length limit, but this limit is not checked in the Coffeescript or Python code, so it is only enforced at the very end of updating when we try to create the SQL row.
Changes
Now the changelog length is checked on the client and on the server, and a user friendly error message is generated if it's too long. I believe this will happen before the upload starts, so the user won't have to wait for their 5-GiB ZIP file to transfer fully.