Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when editing a part's field #38

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Fix bug when editing a part's field #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin_template/swinfo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"name": "Patch Manager",
"description": "A mod for generic patching needs similar to KSP 1's Module Manager.",
"source": "https://github.com/KSP2Community/PatchManager",
"version": "0.10.0",
"version": "0.10.1",
"version_check": "https://raw.githubusercontent.com/KSP2Community/PatchManager/main/plugin_template/swinfo.json",
"ksp2_version": {
"min": "0.2.0",
Expand Down
8 changes: 6 additions & 2 deletions src/PatchManager.Parts/Modifiables/PartModifiable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,18 @@ public override DataValue GetFieldValue(string fieldName)
var repl = fieldName.Replace("PartComponent", "");
if (JToken is not JObject jObject)
return DataValue.Null;
if(!jObject.ContainsKey("serializedPartModules"))
if (!jObject.ContainsKey("serializedPartModules"))
return DataValue.Null;
foreach (var module in jObject["serializedPartModules"])
{
if (module is not JObject moduleObject)continue;
if (module is not JObject moduleObject) continue;
if (moduleObject.ContainsKey("Name") && ((string)moduleObject["Name"])!.Replace("PartComponent", "") == repl)
return DataValue.FromJToken(module);
}

if (jObject.TryGetValue(fieldName, out var value))
return DataValue.FromJToken(value);

return DataValue.Null;
}

Expand Down
Loading