Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theforeman-rubocop gem #943

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Use theforeman-rubocop gem #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ jobs:
rubocop:
name: Rubocop
uses: theforeman/actions/.github/workflows/rubocop.yml@v0
with:
command: bundle exec rubocop --parallel --format github

test:
name: Tests
Expand Down
16 changes: 4 additions & 12 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,17 @@
# TODO: remove this
inherit_from: .rubocop_todo.yml

inherit_gem:
theforeman-rubocop:
- lenient.yml

AllCops:
TargetRubyVersion: 2.7

MethodLength:
Description: 'Avoid methods longer than 30 lines of code.'
Max: 30 # default is 10

Documentation:
Enabled: false

StringLiterals:
Enabled: false

HashSyntax:
Enabled: false

Expand Down Expand Up @@ -71,12 +69,6 @@ RedundantReturn:
SingleLineBlockParams:
Enabled: false

FormatString:
Enabled: false # we use % for i18n

Style/Alias:
Enabled: false

Style/MultilineMethodCallBraceLayout:
Enabled: false

Expand Down
Loading