Fixes #38236 - copy /run/containers/0/auth.json only if it exists #11323
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Don't fail on copy
/run/containers/0/auth.jsonto/etc/flatpak/oci-auth.jsonif the source file does not exist - its presence is optional.Considerations taken when implementing this change?
There are a few options how to fix this, i.e. redirect stderr to
/dev/null. I chose thiscpoption:for its positive side-effect: dont overwrite
oci-auth.jsonif it has a newer content (at least I see this as a feature and not a bug of the chosen fix - let me see if you think otherwise).What are the testing steps for this pull request?
Ensure no
/run/containers/0/auth.jsonis present on a Host with podman and flatpak (this is default), and apply the job template to the Host.