Skip to content

Commit

Permalink
remove sec, update from pr comments, cleanup golangci.yml to not brea…
Browse files Browse the repository at this point in the history
…k on master
  • Loading branch information
sesheffield committed Jul 29, 2024
1 parent c0ff9cf commit 3e96078
Show file tree
Hide file tree
Showing 4 changed files with 51 additions and 60 deletions.
3 changes: 2 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
# Global rule:
* @rhuairahrighairidh @karzak @pirtleshell @drklee3 @nddeluca @DracoLi @evgeniy-scherbina @sesheffield
* @rhuairahrighairidh @karzak @pirtleshell @drklee3 @nddeluca @DracoLi @evgeniy-scherbina @sesheffield @faddat
13 changes: 2 additions & 11 deletions .github/workflows/ci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,10 @@ jobs:
- name: Load Version
id: load-version
run: |
echo "GOLANGCI_VERSION=v$(cat .golangci-version)"
echo "GOLANGCI_VERSION=$(cat .golangci-version)"
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
with:
version: ${{ steps.load-version.outputs.GOLANGCI_VERSION }}
args: -v -c .golangci.yml
golang-sec:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
with: { fetch-depth: 0 }
- name: Run Gosec Security Scanner
uses: cosmos/[email protected]
with:
args: ./...

2 changes: 1 addition & 1 deletion .golangci-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v1.59
v1.59
93 changes: 46 additions & 47 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,74 +50,73 @@ linters:
- bidichk
- bodyclose
- containedctx
- contextcheck
# - contextcheck
- decorder
- dogsled
- dupl
- dupword
# - dupl
# - dupword
- durationcheck
- errcheck
# - errcheck
- errchkjson
- errname
- errorlint
- exhaustive
- exportloopref
- gci
# - errname
# - errorlint
# - exhaustive
# - exportloopref
# - gci
- ginkgolinter
- gocheckcompilerdirectives
- gochecknoglobals
- gochecknoinits
# - gochecknoglobals
# - gochecknoinits
- goconst
- gocritic
- godox
# - gocritic
# - godox
- gofmt
- gofumpt
# - gofumpt
- goheader
- goimports
- mnd
- gomodguard
# - mnd
# - gomodguard
- goprintffuncname
- gosec
- gosimple
- govet
# - gosec
# - gosimple
# - govet
- grouper
- importas
- ineffassign
- interfacebloat
- lll
# - ineffassign
# - interfacebloat
# - lll
- loggercheck
- makezero
- mirror
- misspell
# - misspell
- musttag
- nakedret
- nestif
- nilerr
- nilnil
- noctx
- nolintlint
- nonamedreturns
# - nakedret
# - nestif
# - nilerr
# - nilnil
# - noctx
# - nolintlint
# - nonamedreturns
- nosprintfhostport
- prealloc
- predeclared
# - prealloc
# - predeclared
- promlinter
- reassign
- revive
# - reassign
# - revive
- rowserrcheck
- sqlclosecheck
- staticcheck
- stylecheck
- tagalign
- testpackage
- thelper
- tparallel
# - staticcheck
# - stylecheck
# - tagalign
# - testpackage
# - thelper
# - tparallel
- typecheck
- unconvert
- unparam
- unused
- usestdlibvars
- wastedassign
- whitespace
# - unconvert
# - unparam
# - unused
# - usestdlibvars
# - wastedassign
# - whitespace

issues:
exclude-rules:
Expand Down

0 comments on commit 3e96078

Please sign in to comment.