chore: allow override of go binary in Makefile #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galxy25
approved these changes
Aug 9, 2023
pirtleshell
force-pushed
the
rp-make-go-bin-var
branch
2 times, most recently
from
8884f2b
to
6e4244b
Compare
pirtleshell
force-pushed
the
rp-make-go-bin-var
branch
from
6e4244b
to
b07d428
Compare
nddeluca
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updates all hardcoded references to
goin theMakefileto allow overriding with an env variableGO_BIN. this can allow runningmakecommands with different go binaries, like if you need to build with a different go version.i expect to backport this to all
kava_2222-10release branches (v0.17, v0.18, v0.19, v0.21, v0.23, v0.24)Checklist