Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rocksdb configurable (backport #1658) #1697

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 5, 2023

NOTE:

  • change ethermint dependency from path to tag before merge

This is an automatic backport of pull request #1658 done by Mergify.
Cherry-pick of 90fbe1a has failed:

On branch mergify/bp/release/v0.17.x/pr-1658
Your branch is up to date with 'origin/release/v0.17.x'.

You are currently cherry-picking commit 90fbe1aa.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Makefile
	new file:   cmd/kava/opendb/opendb.go
	new file:   cmd/kava/opendb/opendb_rocksdb.go
	new file:   cmd/kava/opendb/opendb_rocksdb_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/ci-rocksdb-build.yml
	deleted by us:   Dockerfile-rocksdb
	both modified:   cmd/kava/cmd/root.go
	both modified:   go.mod
	both modified:   go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Make rocksdb configurable

* Make sure rocksdb tests are running in CI

* Updating ci-rocksdb-build workflow

* Remove test.sh

* Update tm-db dependency

(cherry picked from commit 90fbe1a)

# Conflicts:
#	.github/workflows/ci-rocksdb-build.yml
#	Dockerfile-rocksdb
#	cmd/kava/cmd/root.go
#	go.mod
#	go.sum
* Rocksdb Metrics

* Add rocksdb namespace for options

* Adding help to the metrics

* CR's fixes

* CR's fixes

* CR's fixes
go.mod Outdated
// Use ethermint fork that respects min-gas-price with NoBaseFee true and london enabled, newProto w/ height parameter
github.com/tharsis/ethermint => github.com/Kava-Labs/ethermint v0.14.0-kava-v17.4
//github.com/tharsis/ethermint => github.com/Kava-Labs/ethermint v0.14.0-kava-v17.4
github.com/tharsis/ethermint => /Users/yevheniishcherbina/go/src/github.com/evmos/ethermint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending tag update here

@evgeniy-scherbina evgeniy-scherbina merged commit c81a1c3 into release/v0.17.x Sep 6, 2023
1 check passed
@evgeniy-scherbina evgeniy-scherbina deleted the mergify/bp/release/v0.17.x/pr-1658 branch September 6, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants